Re: [boost] Re: Review Results: Base-from-Member

From: Ed Brey (edbrey_at_[hidden])
Date: 2001-08-17 08:58:17

From: "Daryle Walker" <darylew_at_[hidden]>
>
> > * Issues raised during the review be addressed, particularly Ed Brey's
> > http://groups.yahoo.com/group/boost/message/15406.  (Note that Daryle
has
> > already dealt with some issues in an update in the files section.)
>
> I think I covered every issue.  Do you have any specific concerns?

I just took a look at your update in the files section (version 11).  I
still have a couple concerns.  One problem is the existence of two
first-class interfaces, one a set of classes of the form
base_from_member_n and the other the class base_from_member.  To be
minimal and complete the former interface should be dropped.  The only
exception is that if there are still a significant number of compilers
still around that chock on the latter.  Do you know of any (even MSVC6
works here!)?  I think this would have to be pretty major before we should
allow expanding the interface (only to have to deprecated, but still
maintain, it later) to appease them, since the obvious workaround of just
implementing the pattern by hand is quite reasonable.

Likewise, the documentation should be updated accordingly.  I see getting
these issues resolved solidly as much more important than getting this
library into the next possible release.