Re: [boost] Re: Formal Review: Circular Buffer

From: Jan Gaspar (jano_gaspar_at_[hidden])
Date: 2004-03-05 01:42:48

Hi Pavel!
 
> ________________________________________________
> 1. docs: the table "Friend Functions" should
>    be rather "Standalone Functions" and should
> mention
>    swap, <=, >= as well.
Agree.

> ________________________________________________
> 2. base.hpp: standalone function
>    bool operator > (...) should be added.
It is there!

template <class T, class Alloc>
inline bool operator >(const circular_buffer<T,Alloc>&
lhs, const circular_buffer<T, Alloc>& rhs) {
    return rhs < lhs;
}

> ________________________________________________
> 3. docs: why is the (SGI) in paragraph
>    "Model of" and why it is twice there?
The (SGI) is there because it is different from the
standard. See
http://boost.org/libs/concept_check/reference.htm for
details.

> ________________________________________________
> 4. docs: "Type Requirements": doesn't the T need
>    to be DefaultConstructible as well, e.g.
>    to support push_back(void)?
Yes, but DefaultConstructible is needed only if you
use such a method. In general it is not needed. For
example you can just create empty circular_buffer and
use push_back(T&). In this case T doesn't have to be
DefaultConstructible.
 
>    Maybe the title should be "Element Type
> Requirements".
OK.

Jan

__________________________________
Do you Yahoo!?
Yahoo! Search - Find what you’re looking for faster
http://search.yahoo.com