RE: [boost] Re: [ANN] Phoenix-2 Preview

From: Eyal Farago (eyal.farago_at_[hidden])
Date: 2004-11-29 07:34:20

I'm not that familiar with phoenix (yet) but I think your implementation fails to handle const arguments. 
I think that the return type deduction mechanizm should first 'remove_cv' the argument type, then get the appropriate type from your existing metafunction, then 'add_const' if the argument was const and then 'add_reference'. (all of these can be easily done using boost::mpl and boost::type_traits libs).

am I missing anything? maybe the framework does this for you?

eyal.

-----Original Message-----
From: Reece Dunn [mailto:msclrhd_at_[hidden]]
Sent: Monday, November 29, 2004 2:06 PM
To: boost_at_[hidden]
Cc: spirit-general_at_[hidden]; spirit-devel_at_[hidden]
Subject: [boost] Re: [ANN] Phoenix-2 Preview

Joel wrote:
> Reece Dunn wrote:
>> I have written lazy veraions of pair.first and pair.second (see 
>> attachment).
> 
> Nice! Seems like a beginning of a utility module. If you'd like
> to submit it as part of the library, I'd need a test program.

Done. Note that the libs/spirit/phoenix/test/Jamfile.v2 needs

+ # bring in rules for testing
+ import testing ;

at the top to allow you to run bjam from that directory, otherwise it 
complains about 'run' being unrecognised.

> I'd also
> request conformance with the implied coding styles for the sake
> of consistency.

Done.

> Many thanks!

:)

Regards,
Reece