Re: [boost] [boost.python] Wrong version check?

From: David Abrahams (dave_at_[hidden])
Date: 2005-11-30 14:07:28

Daryle Walker <darylew_at_[hidden]> writes:

> On 11/29/05 4:27 PM, "Jason Kankiewicz" <jkankiewicz_at_[hidden]> wrote:
>
>> +# elif (defined(__GNUC__) && ((__GNUC__ >= 3 && __GNUC_MINOR__ >=5) ||
>> __GNUC__ >= 4))
>
> Shouldn't the check for GCC 3.x be:
>
>     __GNUC__ == 3 && __GNUC_MINOR__ >= 5
>
> instead of the currently over-broad version?  Otherwise version numbers like
> 4.6 or 5.9 would match on that phrase, which is wrong.  They should match on
> the "__GNUC__ >= 4" phrase instead.  

Well, that would certainly be clearer, but it is semantically
equivalent, is it not?

> The problem phrase should only match on
> 3.5 through 3.9.x.

"problem phrase?"

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com