Re: [boost] Boost inspection notification (2006-09-28/RC_1_34_0) *X*

From: Daniel James (daniel_james_at_[hidden])
Date: 2006-09-29 06:13:15

On 29/09/06, Daniel James <daniel_james_at_[hidden]> wrote:
> On 29/09/06, Roland Schwarz <roland.schwarz_at_[hidden]> wrote:
> >
> > BTW.: a "fix" like the following I think will not be caught by inspect,
> > while still potentially being able to violate ODR.
> >
> > namespace {
> > #include <boost/foo.ipp>
> > }
> >
> > True?
> >
>
> Please don't try to trick inspect, just use 'boostinspect:nounnamed' -
> with a note on why you've used it. This will be clearer to readers and
> easier to grep. This is probably the best thing to on the RC_1_34_0
> branch.

Oh sorry, on second thoughts I think I misinterpreted you. It doesn't
really matter if inspect doesn't catch this kind of thing - it should
be obvious that we shouldn't write it in the first place. But I think
inspect will complain as that's present in a header.

It's actually fairly easy to trick inspect - as it's regular
expression based. But we assume no one is going to do that.