Re: [boost] Compile-time assert

From: Johan Paulsson (boost.org_at_[hidden])
Date: 2006-11-09 14:18:51

David Abrahams wrote:
> Johan Paulsson <boost.org_at_[hidden]> writes:
> 
>> In this case, with the compilers I used, I do not see a big difference 
>> in quality of the error message.
> 
> Of course not, especially because in this case you seem to have left
> out all but the very useless ASSERT(false) case.

I can find two problems with what I posted.

First:

I do not mention that the compilations instantiate the code with the 
compile-time assertions with booth traits_::base = 10 and traits_::base 
= 16.

I suppose this means booth the ASSERT(true) and ASSERT(false) case.

Second:

My use of:
BOOST_MPL_ASSERT((::boost::mpl::integral_c<bool, traits_::base == 10>));
could be improved to something similar to:
BOOST_MPL_ASSERT((base_not_10<traits_::base>));

This would produce a compiler error containing something similar to:
'assertion_failed(mpl_::failed************ base_not_10<16>::************)'

I think this would have been better as it is similar to what I used with 
my own implementation. Please accept my apologies.

I have removed all files from <http://www.kuodo.com/code/assert/deep/> 
because I feel they can not be used for a fair comparation of the error 
messages.

If there are more issues, please tell me.

The last thing I want to do is upset anyone or spread false information, 
if I have I am sorry.

Thank You,
Johan Paulsson