From: Beman Dawes (bdawes_at_[hidden])
Date: 2007-11-02 10:04:17
David Deakins wrote:
> Beman Dawes wrote:
>> David Deakins wrote:
>>> The config
>>> headers already define BOOST_NO_GETSYSTEMTIMEASFILETIME to flag this
>>> situation and the patch uses this define to mark when the alternate
>>> function calls should be substituted.
>> Same comment as for Boost.System. Wouldn't it be better to rely on
>> _WIN32_WCE to enable the workaround?
> In general I have been bracketing these sorts of workarounds with the
> #if defined(UNDER_CE) statement, but in those two cases there appeared
> to be pre-existing macros (BOOST_NO_GETSYSTEMTIMEASFILETIME in
> boost\config\compiler\visualc.hpp and BOOST_NO_ANSI_APIS in
> boost\config\platform\win32.hpp). I believe both were originally
> introduced to support Boost.Threads and came about some time ago. I
> personally have no preference though, and can certainly recast the WinCE
> patches not to use them or to use an alternate macro name. Just let me
> know where the consensus lies and I'll move that direction.
I didn't realize BOOST_NO_ANSI_APIS came from config. Ignore my comment.
Your patch is fine as submitted.
Boost list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk