Re: [boost] [review] Fast track formal review of Forward library begins today

From: David Abrahams (dave_at_[hidden])
Date: 2007-12-04 12:32:19

on Mon Dec 03 2007, John Torjo <john.groups-AT-torjo.com> wrote:

>      * What is your evaluation of the design?

Looks good to me.

>      * What is your evaluation of the implementation?

Also looks good, although I don't understand the PP approach being
used.  It certainly looks different from the very fast one that Paul
Mensonides put together for me once (attached at bottom), but I'm
willing to believe it's better.  Comments would be helpful.

It should use compressed_pair to store the wrapped function object to
take advantage of EBO.

>      * What is your evaluation of the documentation?

Nice, but terse.  It would probably be helpful to many to add some
more material explaining the forwarding problem.

>      * What is your evaluation of the potential usefulness of the
>      library?

Huge

>      * Did you try to use the library? With what compiler?
>        Did you have any problems?

No, n/a, and no

>      * How much effort did you put into your evaluation?
>        A glance? A quick reading? In-depth study?

A quick reading

>      * Are you knowledgeable about the problem domain?

Yeah

> And finally, every review should answer this question:
>
>      * Do you think the library should be accepted as a Boost
>      library?

Absolutely.



-- 
Dave Abrahams
Boost Consulting
http://www.boost-consulting.com