Re: [boost] [Boost.test]Missing vsnprintf on SunOS

From: Gennadiy Rozental (rogeeff_at_[hidden])
Date: 2007-12-11 01:39:56

"K. Noel Belcourt" <kbelco_at_[hidden]> wrote in message 
news:215A3420-9F56-4C59-AA8C-7E96E98C2493_at_sandia.gov...
> Hi,
>
> In execution_monitor.ipp, these macros protect the inclusion of
> stdarg.h on the Sun.
>
> #if defined(__SUNPRO_CC) && defined(__SunOS)
>
> On our system:
>
> sass8000(217 ^H)% uname -a
> SunOS sass8000 5.10 Generic_118833-36 sun4u sparc SUNW,Sun-Fire
>
> The macro __SUNPRO_CC is defined but __SunOS is not defined.  Here's
> the set of macros defined by the sun-5.7 compiler:
>
> " -D__SunOS_5_10 -D__SUNPRO_CC=0x570 -Dunix -Dsun -Dsparc -D__sparc -
> D__sparcv8plus -D__unix -D__sun -D__BUILTIN_VA_ARG_INCR -D__SVR4 -
> D__SUNPRO_CC_COMPAT=5 -D__SUN_PREFETCH
>
> I'd like to change the test in execution_monitor.ipp to permit either
> macro to include the necessary headers, like this:
>
> #if defined(__SUNPRO_CC) || defined(__SunOS)
>
> The patch is attached, okay to commit this?

You can commit, if you can test this on all hardware platforms Sun compiler 
can be used. Specifically on one you are using and Sun Sparc and Sun on 
Intel.

Gennadiy