Re: [boost] Ann: Floating Point Utilities Review starts today

From: John Maddock (john_at_[hidden])
Date: 2008-02-25 13:38:13

> 3) C++ locale facets: these will read and write non-finite numbers in
> a portable and round-trippable way: that is not otherwise possible
> with
> current C++ std library implementations.  These are particularly
> useful for number-serialisation for example.

There are quite a few test failures from these, I'm hoping these are related 
to these facets rather than the underlying utility code:

MSVC-8 (debug)

Running 8 test cases...
nonfinite_num_facets/legacy_test.cpp(120): error in "legacy_test": check 
(isnan)
(b11) failed
nonfinite_num_facets/legacy_test.cpp(138): error in "legacy_test": check 
ss.rdst
ate() == std::ios_base::eofbit failed
nonfinite_num_facets/legacy_test.cpp(120): error in "legacy_test": check 
(isnan)
(b11) failed
nonfinite_num_facets/legacy_test.cpp(138): error in "legacy_test": check 
ss.rdst
ate() == std::ios_base::eofbit failed
nonfinite_num_facets/legacy_test.cpp(120): error in "legacy_test": check 
(isnan)
(b11) failed
nonfinite_num_facets/legacy_test.cpp(138): error in "legacy_test": check 
ss.rdst
ate() == std::ios_base::eofbit failed
nonfinite_num_facets/legacy_test.cpp(120): error in "legacy_test": check 
(isnan)
(b11) failed
nonfinite_num_facets/legacy_test.cpp(138): error in "legacy_test": check 
ss.rdst
ate() == std::ios_base::eofbit failed
nonfinite_num_facets/legacy_test.cpp(120): error in "legacy_test": check 
(isnan)
(b11) failed
nonfinite_num_facets/legacy_test.cpp(138): error in "legacy_test": check 
ss.rdst
ate() == std::ios_base::eofbit failed
nonfinite_num_facets/legacy_test.cpp(120): error in "legacy_test": check 
(isnan)
(b11) failed
nonfinite_num_facets/legacy_test.cpp(138): error in "legacy_test": check 
ss.rdst
ate() == std::ios_base::eofbit failed

*** 12 failures detected in test suite "Master Test Suite"

MSVC-8 (release + SSE2)

Running 8 test cases...
nonfinite_num_facets/basic_test.cpp(167): error in "basic_test": check 
ss.str()
== s failed
nonfinite_num_facets/basic_test.cpp(182): error in "basic_test": check 
(signbit)
(b2) failed
nonfinite_num_facets/basic_test.cpp(184): error in "basic_test": check 
(signbit)
(b4) failed
nonfinite_num_facets/basic_test.cpp(167): error in "basic_test": check 
ss.str()
== s failed
nonfinite_num_facets/basic_test.cpp(182): error in "basic_test": check 
(signbit)
(b2) failed
nonfinite_num_facets/basic_test.cpp(184): error in "basic_test": check 
(signbit)
(b4) failed
nonfinite_num_facets/basic_test.cpp(167): error in "basic_test": check 
ss.str()
== s failed
nonfinite_num_facets/basic_test.cpp(182): error in "basic_test": check 
(signbit)
(b2) failed
nonfinite_num_facets/basic_test.cpp(184): error in "basic_test": check 
(signbit)
(b4) failed
nonfinite_num_facets/basic_test.cpp(167): error in "basic_test": check 
ss.str()
== s failed
nonfinite_num_facets/basic_test.cpp(182): error in "basic_test": check 
(signbit)
(b2) failed
nonfinite_num_facets/basic_test.cpp(184): error in "basic_test": check 
(signbit)
(b4) failed
nonfinite_num_facets/basic_test.cpp(167): error in "basic_test": check 
ss.str()
== s failed
nonfinite_num_facets/basic_test.cpp(182): error in "basic_test": check 
(signbit)
(b2) failed
nonfinite_num_facets/basic_test.cpp(184): error in "basic_test": check 
(signbit)
(b4) failed
nonfinite_num_facets/basic_test.cpp(167): error in "basic_test": check 
ss.str()
== s failed
nonfinite_num_facets/basic_test.cpp(182): error in "basic_test": check 
(signbit)
(b2) failed
nonfinite_num_facets/basic_test.cpp(184): error in "basic_test": check 
(signbit)
(b4) failed
nonfinite_num_facets/lexical_cast_test.cpp(86): error in 
"lexical_cast_test": ch
eck lexical_cast<std::basic_string<CharType> >(a9) == s9 failed
nonfinite_num_facets/lexical_cast_test.cpp(87): error in 
"lexical_cast_test": ch
eck lexical_cast<std::basic_string<CharType> >(a10) == s10 failed
nonfinite_num_facets/lexical_cast_test.cpp(86): error in 
"lexical_cast_test": ch
eck lexical_cast<std::basic_string<CharType> >(a9) == s9 failed
nonfinite_num_facets/lexical_cast_test.cpp(87): error in 
"lexical_cast_test": ch
eck lexical_cast<std::basic_string<CharType> >(a10) == s10 failed
nonfinite_num_facets/lexical_cast_test.cpp(86): error in 
"lexical_cast_test": ch
eck lexical_cast<std::basic_string<CharType> >(a9) == s9 failed
nonfinite_num_facets/lexical_cast_test.cpp(87): error in 
"lexical_cast_test": ch
eck lexical_cast<std::basic_string<CharType> >(a10) == s10 failed
nonfinite_num_facets/lexical_cast_test.cpp(86): error in 
"lexical_cast_test": ch
eck lexical_cast<std::basic_string<CharType> >(a9) == s9 failed
nonfinite_num_facets/lexical_cast_test.cpp(87): error in 
"lexical_cast_test": ch
eck lexical_cast<std::basic_string<CharType> >(a10) == s10 failed
nonfinite_num_facets/lexical_cast_test.cpp(86): error in 
"lexical_cast_test": ch
eck lexical_cast<std::basic_string<CharType> >(a9) == s9 failed
nonfinite_num_facets/lexical_cast_test.cpp(87): error in 
"lexical_cast_test": ch
eck lexical_cast<std::basic_string<CharType> >(a10) == s10 failed
nonfinite_num_facets/lexical_cast_test.cpp(86): error in 
"lexical_cast_test": ch
eck lexical_cast<std::basic_string<CharType> >(a9) == s9 failed
nonfinite_num_facets/lexical_cast_test.cpp(87): error in 
"lexical_cast_test": ch
eck lexical_cast<std::basic_string<CharType> >(a10) == s10 failed

*** 30 failures detected in test suite "Master Test Suite"

Perhaps perversely, VC8 in release mode, but without the /arch:SSE2 option 
passes all the tests.  Intel-10.1 has similar failures (except in SSE2 
mode!), so this may be iostream's related.

Full review to follow.... John.