[boost] [variant] (was Re: [1.35][lexical_cast][concept check][range] Build error andwarnings with MSVC8 on Warning Level 4)

From: Richard Webb (richard.webb_at_[hidden])
Date: 2008-04-22 05:38:29

Paul A Bristow <pbristow <at> hetp.u-net.com> writes:

> 
> 
> >-----Original Message-----
> >From: boost-bounces <at> lists.boost.org 
> >[mailto:boost-bounces <at> lists.boost.org] On Behalf Of Stephan Diederich
> >Sent: 08 April 2008 20:53
> >To: boost <at> lists.boost.org
> >Subject: [boost] [1.35][lexical_cast][concept check][range] 
> >Build error andwarnings with MSVC8 on Warning Level 4
> >
> >As we tried to update to 1.35 today, we found some warnings with MSVC
> >on Warning Level 4 in:
> >
> >lexical_cast:
> >There was a return statement after a call to throw_exception which
> >causes a unreachable code warning.
> >I can see no problem by just removing that return.
> >see  http://svn.boost.org/trac/boost/ticket/1791
> 

Speaking of unreachable code, i get some similar warnings from variant (when
building in release mode):

boost\variant\detail\visitation_impl.hpp(205) : warning C4702: unreachable code
boost\variant\detail\visitation_impl.hpp(180) : warning C4702: unreachable code
boost\variant\detail\visitation_impl.hpp(252) : warning C4702: unreachable code
boost\variant\detail\visitation_impl.hpp(280) : warning C4702: unreachable code

There are some 'should never be here at runtime:' comments in the code in
question, but it would still be nice to silence the warnings 'officially'.

Thanks,
Richard Webb