Re: [boost] [Boost.Log1]: Bug in boost/log/detail/ts_posix.hpp

From: Jens Seidel (jensseidel_at_[hidden])
Date: 2008-07-09 04:07:37

On Tue, Jun 24, 2008 at 09:49:47PM +0200, Boris wrote:
> On Tue, 24 Jun 2008 16:37:56 +0200, Jens Seidel <jensseidel_at_[hidden]>  
> wrote:
> 
> >[...]OK, for all users of this lib here is the patch:
> >
> >boost/log/detail/ts_posix.hpp:
> >@@ -51,7 +51,7 @@
> >     mutex & operator = ( const mutex & Not_Implemented);
> >     mutex( const mutex & From);
> > public:
> >-    mutex() : m_mutex() {
> >+    mutex() : m_mutex(), m_count(0) {
> >         pthread_mutexattr_t attr;
> >         int res = pthread_mutexattr_init(&attr);
> >         assert(res == 0);
> >
> >I haven't checked whether this occurs in version 2 as well.
> 
> Checked it: m_count is not initialized in  
> boost/logging/detail/ts/ts_posix.hpp in version 2 either.

Boris, you're right! Since it is still not fixed could someone please
commit the initialisation? It's unlikely to cause an error this way ...

Path: http://svn.boost.org/svn/boost/sandbox/logging

PS: John, it would also great if you could evaluate
BOOST_DISABLE_THREADS. I don't use threads (up to now) but have to link
against libpthread (at least with g++ 4.1, other versions do not require
it!?).

Jens