Subject: Re: [boost] Proposal: Monotonic Containers
From: Artyom (artyomtnk_at_[hidden])
Date: 2009-06-09 09:11:25
1st... This code does not compile with gcc-4.3 (mingw)
a) Fix: map.h/set.h -->
- set(Predicate P, Allocator const &A)
- : Set(P, A)
+ set(Predicate Pr, Allocator const &A)
+ : Set(Pr, A)
because it shadows template parameter P.
b) Fix in ./boost/monotonic/storage_base.h
Add #include <boost/cstdint.hpp>
2nd... Never use: #pragma once not portable
3rd... Your allocator is not correct you do not align the pointers
as required by most of architectures. You need to provide
8-16 bytes alignment... According to system
4th... Why don't you use boost::pool? It is debugged and tested
instead of writing new implementation?
5th... Implement ALL constructors of each container. For example
I can call.
this is not supported
6th... This is bad idea to derive from std containers. They to do not
provide virtual destructors. This may be very error prone.
This is just short glance.
--- On Tue, 6/9/09, Christian Schladetsch <christian.schladetsch_at_[hidden]> wrote:
> From: Christian Schladetsch <christian.schladetsch_at_[hidden]>
> Subject: Re: [boost] Proposal: Monotonic Containers
> To: boost_at_[hidden]
> Date: Tuesday, June 9, 2009, 3:06 PM
> That is not what I asked for. I wanted online docs and
> code. We are very
> >> busy people, and anything that takes extra time is
> likely to mean we don't
> >> bother.
> OK well on second thought, what?
> I am also busy.
> I gave you a link to code and documentation in the one
> Click on the link, get the code and the documentation.
> Sorry that you have
> to click into the archive twice, but boost doesn't have a
> better way of
> doing it ATM that I am aware of.
> Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Boost list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk