Boost logo

Boost :

Subject: Re: [boost] Formal Review: Boost.Polygon starts today August 24, 2009
From: Simonson, Lucanus J (lucanus.j.simonson_at_[hidden])
Date: 2009-08-31 12:48:45


Steven Watanabe wrote:
> AMDG
>
> Simonson, Lucanus J wrote:
>> Phil Endecott wrote:
>>
>>> Dear All,
>>>
>>> I've just had a quick attempt at writing a Boost.Polygon traits
>>> specialisation for my rectangle type, and my 10 lines of code
>>> produce 105 warnings that come to 54k of output. This is with g++
>>> 4.1.2. That makes it pretty much unusable for me. Luke, please fix
>>> this and re-submit. I vote to reject the library if this is not
>>> done. I've had a quick look at one of the warnings and it looks
>>> easily fixable; interval_concept.hpp:84 just remove "ptr".
>>>
>>> Regards, Phil.
>>>
>>
>> I'm using ptr as SFINAE guard. I can move SFINAE checks back to the
>> return type and add the MSVC8 workaround. I'll see what I can do
>> about your warnings in 4.1.2.
>>
>
> You don't need to give the parameter a name.
> typename enable_if<...>::type* = 0 works just fine.

Sneaky. I've fixed all the gcc 4.1.2 warnings, which include the long double warnings you was in 3.4.4. I also fixed the tabs since they were on the same lines as the *ptr = 0 which was added in the MSVC8 IDE.

4.1.2 should compile without warnings now.

Thanks,
Luke


Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk