[boost] Move notes

Subject: [boost] Move notes
From: David Abrahams (dave_at_[hidden])
Date: 2009-09-07 15:57:01

Hi Ion,

A few things I noticed looking through move.hpp in the sandbox

1. you static_cast in one direction but reinterpret_cast in the other.
   Why?

2. I think move_iterator's operator-> return type is wrong; maybe make
   the pointer type be the underlying iterator type instead?

3. I think its operator[] can be wrong for some iterators.  See
   http://www.boost.org/doc/libs/1_40_0/libs/iterator/doc/iterator_facade.html#operator

4. bool-valued traits should be derived from an MPL integral constant,
   e.g.

    template <class T>
    struct is_whatever : mpl::bool_< (some compile-time expression ) > {};

Cheers,

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com