Subject: Re: [boost] [new Warnings policy] MS C4180 on the Maintenance Guidelines
From: Emil Dotchevski (emildotchevski_at_[hidden])
Date: 2009-11-19 16:55:31
On Thu, Nov 19, 2009 at 5:21 AM, Stewart, Robert <Robert.Stewart_at_[hidden]> wrote:
> Paul A. Bristow wrote:
>> Steven Watanabe wrote:
>> > Emil Dotchevski wrote:
>> > > Actually, prompted by compile error in Boost Exception on
>> > > GCC 3.4.5,
>> > > triggered by a warning "fix" made just prior to release (see
>> > > http://svn.boost.org/trac/boost/ticket/3641) I think we
>> > > should ban all
>> > > last minute changes (including warning "fixes") that are not
>> > > addressing *bugs*.
>> > +1. Warnings should be suppressed, but fixing them isn't
>> > worth the risk late in the release cycle.
>> Definitely +1 more.
> If a warning can be fixed by changing the code, and the result is
> reasonable and maintainable, and doesn't violate performance
> demands, then the warning should be eliminated by changing the
Two why questions:
- why do you think that changing the code is better?
- why do we care what action was taken to remove a warning?
Reverge Studios, Inc.
Boost list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk