Re: [boost] [xint] Third release is ready, requesting preliminary review

Subject: Re: [boost] [xint] Third release is ready, requesting preliminary review
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2010-05-05 11:06:53

Chad Nelson wrote:
> On 05/04/2010 02:23 PM, Stewart, Robert wrote:
>
> >>> It looks as if you haven't taken advantage of building some of
> >>> the relational operators on the others. For example, >= is !<.
> >>> That is, many of the operators should be inlined and only a few
> >>> need to be implemented.
> >>
> >> I'm not sure I see your point. They all consist of a single
> >> function call and an int comparison, so the compiler will probably
> >> inline them regardless.
> >
> > I didn't see the implementation of those, so I assumed that
> > they were declarations of non-inlined functions.
>
> I believe they are, but I also believe that the compiler is
> smart enough
> to change them to inlined functions. It wouldn't be any major
> difficulty to make that explicit though.
>
> bool operator==(const integer &num1, const integer &num2) {
>     return compare(num1, num2)==0; }
> bool operator!=(const integer& num1, const integer& num2) {
>     return compare(num1, num2)!=0; }
> bool operator<(const integer& num1, const integer& num2) {
>     return compare(num1, num2)<0; }
> bool operator>(const integer& num1, const integer& num2) {
>     return compare(num1, num2)>0; }
> bool operator<=(const integer& num1, const integer& num2) {
>     return compare(num1, num2)<=0; }
> bool operator>=(const integer& num1, const integer& num2) {
>     return compare(num1, num2)>=0; }

Having found the definition of compare() for a previous post, I have now found the definition of those operators.  Since they are in a .cpp file, they cannot be inlined.  You need to move them to integer.hpp (or integer.ipp, if you prefer) for that.

_____
Rob Stewart                           robert.stewart_at_[hidden]
Software Engineer, Core Software      using std::disclaimer;
Susquehanna International Group, LLP  http://www.sig.com

IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.