Re: [boost] [1.46] Last few merges needed?

Subject: Re: [boost] [1.46] Last few merges needed?
From: Rene Rivera (grafikrobot_at_[hidden])
Date: 2011-01-27 11:30:33

On 1/27/2011 10:22 AM, Joachim Faulhaber wrote:
> 2011/1/27 Rene Rivera<grafikrobot_at_[hidden]>:
>> Next time, please start a new thread / subject...
>>
>> On 1/27/2011 9:51 AM, Joachim Faulhaber wrote:
>>>>>
>>>>> Is there likely to be a window when these changes can be merged - maybe
>>>>> between beta and release?
>>>
>>> I have encountered a problem today that I would like to fix and merge
>>> before release:
>>>
>>> When preceded by the include
>>> #include<boost/thread.hpp>
>>>
>>> Boost.Icl code
>>> #include<boost/icl/some_icl_file.hpp>
>>>
>>> does not compile anymore. The problem could be located in macro code:
>>>
>>> BOOST_STATIC_CONSTANT(bool,
>>>      value = (interval_bound_type<Type>::value
>>>              <    icl::interval_bounds::undefined));
>>>
>>> This bug obviously would be very annoying to users, who want to use
>>> Boost.Icl together with Boost.Tread.
>>>
>>> The fix is very tiny and trivial
>>>
>>> BOOST_STATIC_CONSTANT(bool,
>>>      value = ((interval_bound_type<Type>::value)
>>>              <    icl::interval_bounds::undefined));
>>>
>>> parentheses around a subexpression in two lines.
>>>
>>> I've just committed that fix to the trunk after testing locally.
>>>
>>> So I'd like to ask for permission to merge this small fix to the release
>>> branch.
>>
>> Short answer, no. Long answer, this doesn't look like a showstopper to me.
>
> Hmm. The effect makes Boost.Icl almost unusable for users that include
> <boost.thread.hpp>  somewhere before icl stuff. On the other hand the
> fix is pretty trivial. But well, the decision is up to you.

Sure.. But isn't it just as "easy" to tell users to swap the includes 
around? Note.. I'm only being annoying because we are already running 
rather behind on the release :-(

-- 
-- Grafik - Don't Assume Anything
-- Redshift Software, Inc. - http://redshift-software.com
-- rrivera/acm.org (msn) - grafik/redshift-software.com
-- 102708583/icq - grafikrobot/aim,yahoo,skype,efnet,gmail