Re: [boost] Heads up: 1.55.0 deadlines approaching

Subject: Re: [boost] Heads up: 1.55.0 deadlines approaching
From: Daniel James (daniel_at_[hidden])
Date: 2013-09-26 11:46:40

On 26 September 2013 15:49, Vicente J. Botet Escriba
<vicente.botet_at_[hidden]> wrote:
>
> Could I merge this fix once the regression test have cycled
>
> Committed revision 85962. Thread: future::then should join the thread before
> destruction.
> https://svn.boost.org/trac/boost/changeset/85962

Is this a bug fix, or a standards compliance fix? If the former than
yes, such fixes are fine. If the latter then I'm inclined to say yes,
but another release manager might be more knowledgeable than me, or
have another opinion?

Actually, I just had a look at the patch, and I don't think I
understand it. Calling 'join' in the destructor for
'future_async_continuation_shared_state' seems redundant since it
inherits from 'future_async_shared_state_base' and its destructor
calls 'join'. Am I missing something?