Re: [boost] [filesystem, regex, asio] These three libraries successfully ported to Windows Phone 8.1

Subject: Re: [boost] [filesystem, regex, asio] These three libraries successfully ported to Windows Phone 8.1
From: Niall Douglas (s_sourceforge_at_[hidden])
Date: 2015-01-26 10:51:23

On 26 Jan 2015 at 10:53, Moshe Rubin wrote:

> When the code has passed the regression suite I will issue a pull request
> against the GitHub repository. 

Some tips for creating a successful pull request:

1. Avoid #ifdef spam. Write thunk emulations of missing APIs where 
possible. Here's an example for GetTickCount64(): 
https://github.com/boostorg/thread/blob/master/include/boost/thread/wi
n32/thread_primitives.hpp#L290. Remember Boost still supports Windows 
XP and exclusively targets an XP level Win32 API. Use GetProcAddress 
for newer APIs.

2. Avoid using macros to implement functionality.

3. Don't forget to modify the documentation where needed to support 
the changes.

4. It might sound obvious, but make sure the unit test suite still 
passes on Windows XP in default build settings on all of MSVC-8, 
mingw32 and mingw-w64. You'd be surprised how often pull requests 
don't because they use some Vista or later API, or an API not 
supported by mingw32. If a pull request doesn't instantly go all 
green on all supported platforms it tends to not be merged and get 
put off till much later (sometimes forever).

Right now cygwin support is broken at least in thread, but other 
libraries are probably a lot better, so test that too.

5. Consider additional unit tests where appropriate. In this 
situation I'd doubt you'd need them.

And thank you very much for the improved WinRT support.

Niall

-- 
ned Productions Limited Consulting
http://www.nedproductions.biz/ 
http://ie.linkedin.com/in/nialldouglas/