Re: [boost] [rational] Can the community maintenance team and/or rational users please review some pull requests?

Subject: Re: [boost] [rational] Can the community maintenance team and/or rational users please review some pull requests?
From: Andrzej Krzemienski (akrzemi1_at_[hidden])
Date: 2015-04-01 08:17:41

2015-03-30 19:16 GMT+02:00 Marc Glisse <marc.glisse_at_[hidden]>:

>
> If I understand correctly, cpp_rational is constructible from double but
> rational isn't?

That is incorrect rational is (inadvertently) constructible from double.
Check it out (with 1.57):

#include <boost/rational.hpp>

int main()
{
  boost::rational<int> r = 2.5;
  assert (boost::rational<int>(2) == r);
}

With an unfortunate results. This is a serious bug.

Regards,
&rzej