Re: [boost] [afio] AFIO review postponed till Monday

Subject: Re: [boost] [afio] AFIO review postponed till Monday
From: Glen Fernandes (glen.fernandes_at_[hidden])
Date: 2015-08-22 15:21:57

On Sat, Aug 22, 2015 at 9:21 AM, Niall Douglas wrote:
> If you want to get started, everything is ready at the usual places
> and the CI dashboard is all green on all supported platforms and
> targets (the one fail was a timeout due to me pushing the CI too
> hard, it's not important).

In my opinion- I don't think you will need to worry about the tests
being all green for a review.

> Today I'll be spending swapping my dev workstation hard drive as I
> killed the poor thing this week during testing the AFIO tutorial
> workshop examples. I'll then press on with finishing the final
> key-value store example which is described in detail in the tutorial
> but is currently without code nor benchmarks. That new code won't be
> part of this review, but I can link to it here with benchmarks when
> it's ready.

One question: Are reviewers also reviewing the  "Monad" and "APIBind"
libraries? (I see them consumed as sub-modules in the AFIO
repository).

Glen