Re: [boost] Boost.Fiber mini-review September 4-13

Subject: Re: [boost] Boost.Fiber mini-review September 4-13
From: Nat Goodspeed (nat_at_[hidden])
Date: 2015-09-04 14:46:18

On Fri, Sep 4, 2015 at 2:24 PM, Agustín K-ballo Bergé
<kaballo86_at_[hidden]> wrote:

> I just had a quick look at the future implementation, to see if proper
> chrono support (one of the reasons for my previous rejection) was
> implemented. While `wait_for` depicts the standard signature, it does not
> seem `wait_until` does.

I want to make it as easy as possible for Oliver to act on people's
feedback. Please suggest a specific change?

> The shared state has a few functions that *must* be called while holding a
> lock, like `mark_ready_and_notify_`. It'd be better to make that explicitly,
> and preferably have the type system enforce it, as currently proving the
> correctness of those functions require tracing all the callers.

Is your suggestion that Fiber's use of its shared_state track more
closely the way Boost.Thread uses its own shared_state?