[boost] Need to use SHA1 implementation in boost

Subject: [boost] Need to use SHA1 implementation in boost
From: Vinnie Falco (vinnie.falco_at_[hidden])
Date: 2016-04-18 06:43:29

Greetings everyone, I'm new to the boost development mailing list.

I'm preparing a library for boost review, and it needs a SHA1
implementation. I have my own header only version I took from the net,
based on https://github.com/vog/sha1.

I see that there's already a SHA1 implementation already in the boost,
its part of UUID:
https://github.com/boostorg/uuid/blob/develop/include/boost/uuid/sha1.hpp

Its bad form to duplicate code, but there are two problems with the
UUID implementation: its in a detail namespace, and it seems to be
completely unoptimized and without the unrolling present in the
commonly used version originally written by Steve Reid (linked above).

What should I do? I'm guessing, some combination of the following:

1. Use UUID SHA1 as-is, even though its in a detail namespace.

2. Submit a pull request to UUID to make the SHA1 class a public
interface. The problem here is the bar for public interfaces is quite
high. I envision endless bike shedding (is "processs_bytes" the right
name?)

3. Additionally submit a pull request to UUID to use the more
optimized version of SHA1

4. Use my own version in my library submission, make it a detail class.

Thanks