Re: [boost] [release] 1.64.0 post-beta merges

Subject: Re: [boost] [release] 1.64.0 post-beta merges
From: Daniel James (dnljms_at_[hidden])
Date: 2017-04-08 19:51:31

On 8 April 2017 at 20:26, Oliver Kowalke via Boost
<boost_at_[hidden]> wrote:
> 2017-04-08 21:16 GMT+02:00 Daniel James via Boost <boost_at_[hidden]>:
>
>> On 8 April 2017 at 19:47, Oliver Kowalke via Boost
>> <boost_at_[hidden]> wrote:
>> >
>> > one part of the commit does code clean-up:
>> >
>> > if (defined(BOOST_EXECUTION_CONTEXT) && (BOOST_EXECUTION_CONTEXT == 1))
>> >
>> > to
>> >
>> > if (BOOST_EXECUTION_CONTEXT == 1)
>>
>> This isn't really the time for cleaning up code.
>>
>
> but it's part of a commit that is necessary that users can select the API

Maybe it shouldn't have been? But as I said, I don't think I can
comment on the rest of the commit. I really don't know enough about
boost build.

>>
>> >>
>> >> > - boost.coroutine2: remove segmented stack example
>> >>
>> >> That look okay to me, but wait for some test results to come in first.
>> >>
>> >
>> > example egmented stack was already commented out in Jamfile, e.g. never
>> > compiler
>> > removing the source and the entry from the Jamfile shouldn't influence
>> the
>> > tests
>>
>> Is it that hard to wait? A day should be enough.
>>
>
> it's not a problem - only dead code (non-compiled example) is removed -> it
> will not influence the results

Then when you check it tomorrow all will be fine. I don't understand
why this is so unbearable and worth spending a Saturday arguing about.
It's a pretty basic precaution.