Re: [boost] Boost 1.65.0 Release Candidate 1

Subject: Re: [boost] Boost 1.65.0 Release Candidate 1
From: Raffi Enficiaud (raffi.enficiaud_at_[hidden])
Date: 2017-08-07 01:03:38

Le 07.08.17 à 02:51, Marshall Clow via Boost a écrit :
> On Sun, Aug 6, 2017 at 3:59 PM, Raffi Enficiaud via Boost <
> boost_at_[hidden]> wrote:
>
>> Le 07.08.17 à 00:04, Tom Westerhout via Boost a écrit :
>>
>>> On 06/08/2017, Marshall Clow via Boost <boost_at_[hidden]> wrote:
>>>
>>>> The release candidates for the 1.65.0 release are now available at:
>>>>
>>>> https://dl.bintray.com/boostorg/release/1.65.0/source/
>>>>
>>>> The SHA256 checksums are as follows:
>>>>
>>>> 0f1352a7738f24b39b564263b66a8c38bc7d984b57406396400474602e961ad3
>>>> boost_1_65_0_rc1.7z
>>>> c2a022d4d6706668ea94b8e799a76e38929e0e34db884ef451fa9d5db6103238
>>>> boost_1_65_0_rc1.tar.bz2
>>>> 7e84a27276792209d48357a0671348768dbf4dd1d4eadbf01b855274208f148d
>>>> boost_1_65_0_rc1.tar.gz
>>>> 537c42771b2351b4ea3eb8e9a13a3423edcd155323d2c14c4606cd23fc22d09f
>>>> boost_1_65_0_rc1.zip
>>>>
>>>> As always, the release managers would appreciate it if you download the
>>>> candidate of your choice and give building it a try. Please report both
>>>> success and failure, and anything else that is noteworthy.
>>>>
>>>
>>> Sure. I've tried building on Linux 3.16 with GCC-7.1.0 and Clang-trunk:
>>>
>>> * Clang-trunk (-std=c++1z -stdlib=libc++)
>>>
>>>   1) Boost.Test failed. There's no bind1st in std:: anymore. Neither is
>>>   there a random_shuffle.
>>>
>>
>> The calls to random_shuffle are protected by
>> #ifdef BOOST_NO_CXX98_RANDOM_SHUFFLE
>>
>> and the ones of bind1st by
>> #ifdef BOOST_NO_CXX98_BINDERS
>>
>> Those preprocessor checks looked ok to me, what am I missing?
>>
>>
> As a test, I added the following lines to
> libs/config/include/boost/config/stdlib/libcpp.hpp:
>
> #if (_LIBCPP_VERSION > 4000) && (__cplusplus > 201402L) &&
> !defined(_LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE)
> #  define BOOST_NO_CXX98_RANDOM_SHUFFLE
> #endif
> #if (_LIBCPP_VERSION > 4000) && (__cplusplus > 201402L) &&
> !defined(_LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE)
> #  define BOOST_NO_CXX98_BINDERS
> #endif
>
> and Boost.Test build successfully.
>
> Locale, Wave, and fiber still failed.
>
> I will prepare a PR for Boost.config.
>
> -- Marshall

Wonderful! many thanks for the super quick analysis and fix!

Raffi