Re: What to do about Boost libraries which use user-defined macros which are not BOOST_ prefixed

From: Glen Fernandes (glen.fernandes_at_[hidden])
Date: 2019-12-16 15:26:43

On Monday, December 16, 2019, Niall Douglas via Boost <boost_at_[hidden]>
wrote:

>
> A problem has arisen which requires input from boost-dev. Some Boost
> libraries define as part of their public API a non-BOOST_-prefixed macro
> which changes the definition of their header files e.g.
>
> PHOENIX_LIMIT
>
> (just to be clear, Phoenix is not the only library doing this)
>
> If we change such macros to be like BOOST_PHOENIX_LIMIT instead, all
> existing code using Boost which sets PHOENIX_LIMIT would potentially
> *silently* break.
>
> What we could decide to do instead is:
>
> #if defined(PHOENIX_LIMIT) && !defined(BOOST_PHOENIX_LIMIT)
> #error In Boost 1.xx PHOENIX_LIMIT was renamed to BOOST_PHOENIX_LIMIT.
> Please upgrade your code to reflect the new name.
> #endif
>
> Or one could just leave PHOENIX_LIMIT named as is.
>
> What would Boost developers prefer we do?
>
> Niall
>
>

I would leave these as-is. Boost isn't defining them.

Glen