|
|
Ublas : |
From: Michael Stevens (mail_at_[hidden])
Date: 2005-07-21 11:02:50
On Wednesday 29 June 2005 17:36, Gunter Winkler wrote:
> Am Dienstag, 28. Juni 2005 18:01 schrieb Michael Stevens:
> > On Friday 24 June 2005 13:38, Gunter Winkler wrote:
> > > the bug found by Vardan was caused by a wrong implementation of
> > > operator += () and operator -= () of matrix_binary. The increment
> > > and decrement operators were already dispatched depending on the
> > > underlying iterator types, but the += and -= had the old behavior.
> > > The patch includes the quick fix to call ++ or -- as often as
> > > requested.
> >
> > I'm not sure if I should commit this now or wait for the full fix.
> > I'm not sure what efficiency we will loose in the common cases. If +=
> > is commonly used then fix will really slow some things down.
>
> I would not commit the patch, because its a quick & dirty fix. But We
> should add an issue at the bug tracker or todo list.
I've attached what I believe to be a complete patch. It adds a couple of
things:
a) Provides a fast computed specialisation for dense
b) Uses ';' instead of ',' to separate simple statements!
c) Works for +ve and -ve n
I propose to commit this fix once Boost 1.33 is branched for release.
Michael
--
___________________________________
Michael Stevens Systems Engineering
34128 Kassel, Germany
Phone/Fax: +49 561 5218038
Navigation Systems, Estimation and
Bayesian Filtering
http://bayesclasses.sf.net
___________________________________