Re: [Boost-bugs] [Boost C++ Libraries] #2346: [type_traits] Patches to improve support for CodeGear C++ Builder 2009

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #2346: [type_traits] Patches to improve support for CodeGear C++ Builder 2009
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2008-10-05 21:36:16

#2346: [type_traits] Patches to improve support for CodeGear C++ Builder 2009
--------------------------------------+-------------------------------------
  Reporter:  nmusatti                 |       Owner:  johnmaddock
      Type:  Patches                  |      Status:  assigned   
 Milestone:  To Be Determined         |   Component:  type_traits
   Version:  Boost Development Trunk  |    Severity:  Problem    
Resolution:                           |    Keywords:             
--------------------------------------+-------------------------------------

Comment(by nmusatti):

 Replying to [comment:1 johnmaddock]:
 > That looks OK, but can you:
 >
 > 1) Add the new config macros to Boost.Config as well?  Not sure about
 this, but I think we are using BOOST_NO_* names for C++0x features as
 well: obviously that means changing the logic quite a bit and patching
 more config files... :-(

 I ended up removing those I hadn't already submitted a patch for.

 > 2) Please use the MPL macros for defining the traits classes rather than
 inheriting from integral_constant directly?  Much as I truely hate those
 macros, they are necessary for full MPL interoperability unfortunately :-(

 I just replaced the boost_type_traits.patch file with a new one. I changed
 the implementation approach to use intrinsics.hpp as much as possible and
 then I tried to be as little intrusive as I could. The resulting patch
 reduces type_traits failing tests to 4 for the bcc32 6.1.0 compiler. Let
 me know if you consider it acceptable.

-- 
Ticket URL: <http://svn.boost.org/trac/boost/ticket/2346#comment:2>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.