Re: [Boost-bugs] [Boost C++ Libraries] #7784: [PATCH] Overlapping strings are not properly handled by string::algo::find_all

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #7784: [PATCH] Overlapping strings are not properly handled by string::algo::find_all
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2013-03-04 16:20:52

#7784: [PATCH] Overlapping strings are not properly handled by
string::algo::find_all
--------------------------------------+-------------------------------------
  Reporter:  cedstrom@…               |       Owner:  marshall   
      Type:  Bugs                     |      Status:  reopened   
 Milestone:  To Be Determined         |   Component:  string_algo
   Version:  Boost Development Trunk  |    Severity:  Problem    
Resolution:                           |    Keywords:             
--------------------------------------+-------------------------------------
Changes (by steven_watanabe):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 Marshall, I don't think that this patch should have been applied.  I
 believe that the library is intended to return non-overlapping matches.
 Rationale: (1) find_all is in split.hpp, the documentation says: "Split
 algorithms can be used to divide a string into several parts...." (2) For
 the sake of consistency, find_all, replace_all, and erase_all, should all
 use the same set of matches.  The patch breaks this. (3)
 boost::regex_iterator also finds non-overlapping matches.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/7784#comment:5>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.