Re: [Boost-bugs] [Boost C++ Libraries] #8433: Algorithm for finding all the elementary circuits in a directed (multi)graph

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #8433: Algorithm for finding all the elementary circuits in a directed (multi)graph
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2013-04-22 20:14:43

#8433: Algorithm for finding all the elementary circuits in a directed
(multi)graph
-------------------------------+--------------------------------------------
  Reporter:  Louis Dionne      |       Owner:  jewillco                             
      Type:  Feature Requests  |      Status:  new                                  
 Milestone:  To Be Determined  |   Component:  graph                                
   Version:  Boost 1.54.0      |    Severity:  Not Applicable                       
Resolution:                    |    Keywords:  graph multigraph circuit cycle hawick
-------------------------------+--------------------------------------------

Comment (by jewillco):

 Here are a few comments on the code:

 * It looks good and is almost ready to put in.
 * There is no documentation file that I can see.
 * Please use `boost::graph_detail::find` from
 `<boost/pending/container_traits.hpp>` instead of `std::find`; that code
 will automatically use a member find to get better performance on types
 such as `set` and `unordered_set`.  If you know that you are searching a
 non-associative container, you can also use `boost::container_contains`
 from `<boost/detail/algorithm.hpp>`.
 * What concept is `ClosedMatrix` expected to model?
 * There is no need to use perfect forwarding on the graph type; passing
 `const` references is fine.  You can also assume vertex descriptors and
 property maps are inexpensive to copy, but forwarding those is acceptable
 if you want to do it.
 * You refer to citation `[1]` in the code, but do not provide the full
 information about the source there.
 * Boost.Graph has a Dot parser (and output routines) if you want to use
 them in your test harness.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/8433#comment:1>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.