[Boost-bugs] [Boost C++ Libraries] #9324: boost\include\boost-1_53\boost\asio\detail\impl\signal_set_service.ipp Off by One Error

Subject: [Boost-bugs] [Boost C++ Libraries] #9324: boost\include\boost-1_53\boost\asio\detail\impl\signal_set_service.ipp Off by One Error
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2013-10-30 16:57:24

#9324: boost\include\boost-1_53\boost\asio\detail\impl\signal_set_service.ipp Off
by One Error
------------------------------------+------------------------------
 Reporter:  Oscar Deits <odeits@…>  |       Type:  Bugs
   Status:  new                     |  Milestone:  To Be Determined
Component:  None                    |    Version:  Boost 1.54.0
 Severity:  Problem                 |   Keywords:
------------------------------------+------------------------------
 In the function

 {{{
 boost::system::error_code signal_set_service::add(
     signal_set_service::implementation_type& impl,
     int signal_number, boost::system::error_code& ec)

 }}}

 The guard statement
 {{{
 // Check that the signal number is valid.
   if (signal_number < 0 || signal_number > max_signal_number)
   {
     ec = boost::asio::error::invalid_argument;
     return ec;
   }
 }}}

 has an Off-by-One error.

 The guard statement should read
 {{{
 // Check that the signal number is valid.
   if (signal_number < 0 || signal_number >= max_signal_number)
   {
     ec = boost::asio::error::invalid_argument;
     return ec;
   }
 }}}

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/9324>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.