Re: [Boost-bugs] [Boost C++ Libraries] #7021: filesystem::path::has_filename() is wrong

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #7021: filesystem::path::has_filename() is wrong
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2014-12-30 20:43:46


#7021: filesystem::path::has_filename() is wrong
-------------------------------+------------------------
  Reporter: cleanrock@… | Owner: bemandawes
      Type: Bugs | Status: closed
 Milestone: To Be Determined | Component: filesystem
   Version: Boost 1.49.0 | Severity: Problem
Resolution: wontfix | Keywords:
-------------------------------+------------------------
Changes (by bemandawes):

 * status: new => closed
 * resolution: => wontfix

Comment:

 Craig Dickson's comment is correct. !m_pathname.empty() is equivalent to
 !filename().empty().

 It is editorially better to document a result in terms of a public
 function than by referring to a private member, while an implementation is
 free to use the private member. It might be a bit cleaner if the
 implementation exactly follows the formulation in the spec, but that
 relies on the compiler to actually inline the function call or is less
 efficient.

 Thanks for your interest in boost.filesystem,

 --Beman

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/7021#comment:2>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.

This archive was generated by hypermail 2.1.7 : 2017-02-16 18:50:17 UTC