[Boost-bugs] [Boost C++ Libraries] #13088: Boost::binomial_heap Merge memcheck error

Subject: [Boost-bugs] [Boost C++ Libraries] #13088: Boost::binomial_heap Merge memcheck error
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2017-06-20 17:46:01

#13088: Boost::binomial_heap Merge memcheck error
------------------------------+--------------------------
 Reporter:  jun.kudo@…        |      Owner:  timblechmann
     Type:  Bugs              |     Status:  new
Milestone:  To Be Determined  |  Component:  heap
  Version:  Boost 1.64.0      |   Severity:  Problem
 Keywords:                    |
------------------------------+--------------------------
 Binomial heap merge routine reads from uninitialized memory in the
 attached example.

 {{{
 #include "boost/heap/binomial_heap.hpp"
 typedef boost::heap::binomial_heap<int> Heap;

 int main(int /*argc*/, char* /*argv*/[]) {
   Heap heap0;
   size_t heap0_size = 3;
   size_t max_range = 100;
   for (size_t ix = 0; ix < heap0_size; ++ix) {
     heap0.push(rand() % max_range);
   }

   Heap heap1;
   size_t heap1_size = 5;
   for (size_t ix = 0; ix < heap1_size; ++ix) {
     heap1.push(rand() % max_range);
   }
   heap0.merge(heap1);
 }
 }}}

 I believe the error stems from the case identified by line 699 in
 binomial_heap.hpp.  If the last node of trees is erased in this line (as
 is the case in this example), this_iterator now points to trees.end().
 However, for this case, it will follow the goto statement and start
 another iteration which will cause the function to again read from
 this_iterator.

--
Ticket URL: <https://svn.boost.org/trac10/boost/ticket/13088>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.