Re: [jamboost] Re: Re: response file problems

From: Vladimir Prus (ghost_at_[hidden])
Date: 2003-03-28 01:54:02

Andre Hentz wrote:
> Hi Vladimir,
>
> On Thu, 27 Mar 2003, Vladimir Prus wrote:
> > toolset.flags builtin.response-file LIBRARY_PATH_OPTION <toolset>msvc :
> > :/LIBPATH: ;
> >
> > to builitin.jam (not to msvc.jam)
>
> I couldn't get this to work. Here's the error message:
>
> ../tools\boost.build\feature.jam:356: in feature.validate-value-string
> from module feature
> error: "msvc" is not a known value of feature <toolset>

That's messy. You can't use <toolset>msvc in builtin jam because msvc is not 
yet configured, and you can't use "toolset.flags builtin.response-file" in
msvc.jam, because an overly carefull "toolset.flags" will complain that you 
define flags for "builtin" module from "msvc". I think I'll eventually fix 
the latter, but for now your solution will do.

> legal values:
> > Once you make the change, I'll be happy to apply your patch.
>
> Find it attached. It uses:
>
> flags builtin.response-file LIBRARY_PATH_OPTION : /LIBPATH: ;

That's OK.

> instead of the version with <toolset>msvc. Let me know if there's anything
> I can do to fix this last bit. 

No thanks, I'll adress this issue later, after some thought.

> BTW, your suggestion made it all much simpler and more elegant.

Alas, I think there's still one bit to be fixed. You've used $(LIBRARY_PATH), 
etc, inside *action* response-file-2. The problem with it is that 
response-file-2 is a piecemeal action. It might be called several times and 
with the subset of sources which can fit to command line. IOW, $(<) will we 
around the command line lenght limit, and
- adding extra elements might overflow
- if not, you'll output the list of searched libraries several times.

I actually meant that 'response-file' *rule* would contain.

print.output $(target) ;
print.text "$(LIBRARY_PATH_OPTION)$(LIBRARY_PATH)" "$(FINDLIBS_ST:S=.lib)" 
; 

Would you mind making this change?

Thanks for your feedback and patience!

- Volodya

P.S. BTW, why did you change prototype for 'searched-lib-generator.run' and 
changed the body? You certainly had some reason, but I wanted to know it so
that it will be documeneted in CVS logs.