Re: [Boost-build] feature treated as a subfeature

Subject: Re: [Boost-build] feature treated as a subfeature
From: Vladimir Prus (ghost_at_[hidden])
Date: 2009-12-18 07:04:35

On Friday 18 December 2009 13:58:35 Vladimir Prus wrote:

> On Friday 18 December 2009 13:13:52 you wrote:
> 
> > On Tuesday 09 September 2008 00:40:22 K. Noel Belcourt wrote:
> > 
> > > 
> > > On Sep 8, 2008, at 2:21 PM, K. Noel Belcourt wrote:
> > > 
> > > > When building on my Linux system, with the sun-5.9 compilers, I try
> > > > to use the stdlib=sun-stlport feature (defined in sun.jam).  I get
> > > > this error from the build system.
> > > >
> > > > bjam sun-5.9 stdlib=sun-stlport
> > > >
> > > > /var/scratch/boost/tools/build/v2/build/feature.jam:466: in validate-
> > > > value-string from module feature
> > > > error: "sun" is not a known value of feature <stdlib>
> > > > error: legal values: "native" "sun-stlport" "stlport"
> > > 
> > > I've attached a patch which seems to fix this problem and, hopefully,  
> > > doesn't cause any other problems.  Can someone look this over and see  
> > > if it looks okay?  Basically the patch says if a feature has a  
> > > subfeature (which <stdlib> does) and the value-string (sun-stlport)  
> > > is not in the list of valid features ( $($(feature).values) ), then  
> > > proceed as before (split the string into subfeatures and validate the  
> > > subfeatures.
> > 
> > After an embarrassing delay, I've checked in
> > this change (suitably adjusted for recent changes):
> > 
> > 	https://svn.boost.org/trac/boost/changeset/58451
> > 
> > Noel, could you check whether you still need any local changes in feature.jam?
> 
> Hmm, it looks like there was a previous attempt at fixing the same
> bug:
> 
> 	https://svn.boost.org/trac/boost/ticket/2030
> 	https://svn.boost.org/trac/boost/changeset/51893
> 
> I guess that only the change I've committed today is really needed?
> 
> - Volodya
> 
> 

- Volodya