[Boost-commit] svn:boost r64310 - sandbox/SOC/2010/process/boost/process

Subject: [Boost-commit] svn:boost r64310 - sandbox/SOC/2010/process/boost/process
From: boris_at_[hidden]
Date: 2010-07-23 20:00:31

Author: bschaeling
Date: 2010-07-23 20:00:31 EDT (Fri, 23 Jul 2010)
New Revision: 64310
URL: http://svn.boost.org/trac/boost/changeset/64310

Log:
Removed line to throw exception if closing thread handle fails
Text files modified: 
   sandbox/SOC/2010/process/boost/process/operations.hpp |     5 +++--                                   
   1 files changed, 3 insertions(+), 2 deletions(-)

Modified: sandbox/SOC/2010/process/boost/process/operations.hpp
==============================================================================
--- sandbox/SOC/2010/process/boost/process/operations.hpp	(original)
+++ sandbox/SOC/2010/process/boost/process/operations.hpp	2010-07-23 20:00:31 EDT (Fri, 23 Jul 2010)
@@ -314,8 +314,9 @@
         envstrs.get(), workdir.get(), &startup_info, &pi) == 0)
         BOOST_PROCESS_THROW_LAST_SYSTEM_ERROR("CreateProcess() failed");
 
-    if (!CloseHandle(pi.hThread))
-        BOOST_PROCESS_THROW_LAST_SYSTEM_ERROR("CloseHandle() failed");
+    // Don't throw an exception if CloseHandle() fails as we would
+    // leak the process handle in pi.hProcess.
+    CloseHandle(pi.hThread);
 
     return child(pi.hProcess,
         detail::file_handle(ctx.stdin_behavior->get_parent_end()),