Re: [Boost-maint] [EXTERNAL] PING: Another patch request

Subject: Re: [Boost-maint] [EXTERNAL] PING: Another patch request
From: Marshall Clow (mclow.lists_at_[hidden])
Date: 2014-02-06 12:40:38

On Feb 6, 2014, at 9:00 AM, Daniela Engert <dani_at_[hidden]> wrote:

> Am 06.02.2014 15:04 schrieb Marshall Clow:
>> On Feb 6, 2014, at 4:29 AM, Beman Dawes <bdawes_at_[hidden]> wrote:
>> On Thu, Feb 6, 2014 at 2:44 AM, Ahmed Charles <acharles_at_[hidden]> wrote:
>> 
>>>>> Someone proposes a change, others review it.
>>>>> But it won’t work if no one looks at other people’s changes.
>>>> I got the mail, but there wasn't a patch attached, otherwise I would've
>>>> looked at it.
>>> IIRC, the oddly named GitHub "Gist" mechanism gives us a place to put
>>> patches if passing them around as attachments is too cumbersome.
>>> 
>>> could document how this works. I'm totally tied up for the
>>> 
>> If someone else wants to document it, that would be great.
>> 
> Well, what's wrong with good ol' pull requests? This mechanism seems to
> work really well and I've been following this path a few times in the
> recent past when contributing to signals2 (Frank Mori Hess) and
> program_options (Vladimir Prus). Once you've opened a pull request from
> a feature branch in your repository clone, you can discuss it, refine
> it, and rebase it to 'develop' head until it's ready to be merged to
> 'develop’.

Nothing is wrong will pull requests.
We just haven’t gotten any of them yet. ;-)

I wrote:
> P.S.	My next change to function will be as simple as the last one, but I’m going to make it a pull request to see how well it works.

and then didn’t do that :-(

— Marshall