Re: [Boost-maint] [dynamic_bitset] Fixes for various tickets.

Subject: Re: [Boost-maint] [dynamic_bitset] Fixes for various tickets.
From: Ahmed Charles (acharles_at_[hidden])
Date: 2014-02-28 22:36:17

----------------------------------------
> From: mclow.lists_at_[hidden]
> Date: Fri, 28 Feb 2014 14:48:16 -0800
> To: boost-maint_at_[hidden]
> Subject: Re: [Boost-maint] [dynamic_bitset] Fixes for various tickets.
>
> On Feb 25, 2014, at 11:52 PM, Ahmed Charles <acharles_at_[hidden]> wrote:
>
>> https://github.com/boostorg/dynamic_bitset/pull/5
>>
>> [second one snipped]
>>
>> The first fixes the following tickets: 8344, 9621, 6947, 6164 and 8445
>
> I thought that 8344 was already fixed.

Yeah, that was a typo on my part. I got confused because one of the changes fixes other MSVC warnings, even though there isn't a bug.

> The fix for 9621 looks fine to me. (and shouldn’t need additional tests)
>
> The code for 6947 (move assignments, etc) - does that code work for self-move? Does it need to?
> (yes, it’s a pathological case, but …)
> Other than that it looks fine.

It was broken, I fixed it. And I added a test for it.

> The code for and tests for 6164 (test and set) look good to me (thought I suspect that the comments on line 615/620/625 of the test are now inaccurate)

They still seem accurate, since they are commenting on the value passed to the second argument of the function, the position.

> The code and tests for 8445 (all) look fine.
>
> Thanks for doing this!


Thanks.