On Fri, Jun 25, 2010 at 4:13 PM, W.P. McNeill <billmcn@gmail.com> wrote:

I'll add the Boost license.

I can change the capitalization convention. It's just aesthetics to me, and it makes sense in this context to be consistent with the rest of Boost.

I have tabs in my source code. It looks like Github's source has a tabs-to-spaces conversion that's different than my editor and makes some lines look weird. I can change this easily enough.

Is there a style guide for Boost and/or the BGL? (Quick Googling didn't turn up anything.)

Is there a particular reason to use iterator_facade rather than forward_iterator_helper?

On Fri, Jun 25, 2010 at 1:53 PM, Jeremiah Willcock <jewillco@osl.iu.edu> wrote:

On Fri, 25 Jun 2010, W.P. McNeill wrote:

I'd be happy to include this in the examples directory. Just point me to the appropriate license boilerplate.
I used forward_iterator_helper because that's what the Knight's Tour example in the Boost Graph Library book uses. If you can see any
other implementation or stylistic issues, let me know. I'd like to make this a good example.

License information is at <URL:http://www.boost.org/users/license.html>. The one thing I didn't like about the code is that it uses a different capitalization convention than Boost; Boost normally uses the STL convention of lowercase words separated by underscores. I don't know if this is a GitHub issue, but it looked like the indentation of your code was inconsistent. Remember that tabs are forbidden in Boost, too (I don't know if your code has them). If you post a new version of the code, I'll look through it again.

-- Jeremiah Willcock

_______________________________________________
Boost-users mailing list
Boost-users@lists.boost.org
http://lists.boost.org/mailman/listinfo.cgi/boost-users