<div dir="ltr">Hi,<br><div><div class="gmail_extra"><br><div class="gmail_quote">2014-11-11 1:53 GMT+01:00 Branimir Betov <span dir="ltr">&lt;<a href="mailto:bbetov@gmail.com" target="_blank">bbetov@gmail.com</a>&gt;</span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div><div><div>Hi,<br><br></div>I am trying to work with boost 1.57 and also I&#39;ve got the geometry.extensions.gis from the develop branch. I am using geographic cs. Looking at extensions\gis\geographic\strategies\andoyer.hpp I think there is a problem with one of the constructors:<br><br>    explicit inline andoyer(RadiusType f)<br>        : m_ellipsoid(f)<br>    {}<br><br></div>I think should be:<br><br>    explicit inline andoyer(RadiusType f)<br>        : m_ellipsoid(f<b>, f</b>)<br>    {}<br><br></div>(note the second radius passed to m_ellipsoid). Otherwise it chooses the incorrect constructor for the ellipsoid and distances are incorrect.<br><br></div></div></div></blockquote><div><br></div><div>I&#39;m not entirely sure what&#39;s the purpose of this ctor and one-argument ctor of ellipsoid. I&#39;d say that the intention was to create a &quot;unit&quot; ellipsoid with radius=1 and flattening f, but there is an error in the ellipsoid ctor (it doesn&#39;t set B, only A and F). There is a reference to a unit sphere (not ellipsoid) in the comment:<br><br><table class=""><tbody><tr><td id="LC45" class=""><span class=""><span class="">//</span> Unit sphere</span></td>
      </tr>
      <tr>
        
        <td id="LC46" class="">        <span class="">ellipsoid</span><span class="">(</span>T <span class="">const</span>&amp; f<span class="">)</span></td>
      </tr>
      <tr>
        
        <td id="LC47" class="">            <span class="">:</span> m_a(<span class="">1.0</span>)</td>
      </tr>
      <tr>
        
        <td id="LC48" class="">            , m_f(f)</td>
      </tr>
      <tr>
        
        <td id="LC49" class="">        {}</td></tr></tbody></table><br><a href="https://github.com/boostorg/geometry/blob/develop/include/boost/geometry/extensions/gis/geographic/detail/ellipsoid.hpp">https://github.com/boostorg/geometry/blob/develop/include/boost/geometry/extensions/gis/geographic/detail/ellipsoid.hpp</a><br><br></div><div>I plan to clean this code and move from extensions in the near future. I think that this ctor could just dissapear. In the meanwhile I may just fix it by setting B properly.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div></div><div>Sorry for posting it in the groups - I am not sure what the proper way to submit a patch is.<br></div><br></div></div></blockquote><div><br></div><div>This group is a right place for such discussion :)<br><br></div><div>A patch could be sent to this group or proposed directly on GitHub. I personally prefer the latter. Here is a tutorial: <a href="https://github.com/boostorg/geometry/wiki/Contribution-Tutorial">https://github.com/boostorg/geometry/wiki/Contribution-Tutorial</a><br></div><div><br></div><div>Regards,<br>Adam<br></div></div></div></div></div>