Re: [Threads-devel] win32 get_milliseconds_until_time

From: Anthony Williams (anthony_at_[hidden])
Date: 2006-08-07 12:18:21

Roland Schwarz <roland.schwarz_at_[hidden]> writes:

> While trying to get the bbv2 build done I discovered that the 
> get_milliseconds_until_time possibly could return invalid values.
>
> This has been reported by the compiler since the default is now
> /W3. In bbv1 it was /W2 (the compiler default).
>
> I tried to correct this, and checked it in.

I've updated it to remove the magic numbers, especially in get_xtime_sentinel

> @Anthony, there still is another warning present, about conversion of a 
> long to a bool. Although it is only a performance warning, I think we 
> are better off, having no warnings at all. What do you think?

We're best off with no warnings.

Anthony
-- 
Anthony Williams
Software Developer
Just Software Solutions Ltd
http://www.justsoftwaresolutions.co.uk