Re: [boost] Review: Regular Expression Library

From: Beman Dawes (beman_at_[hidden])
Date: 2000-08-17 08:21:37

John Maddock wrote:

 >>*  Having a class named "reg_match" and a function named "regex_match"
 >>caused some confusion.  Consider renaming reg_match to
 >regex_match_results,
 >>match_results, or similar.
 >
 >Point taken, I would like to preserve some kind of backwards 
compatibility
 >though for existing users - I guess deriving reg_match from match_results
 >or whatever would do it (but not documenting reg_match), I'd like to keep
 >the name not too long though - what do people prefer for the name of 
this,
 >ideas?

match_results is fine with me.  Your backwards compatibility workaround is 
also fine; do document in the source code why the derivation is there.

 >>*  vc6.bat:  Had to add -I to nmake command so del command failures
 >>wouldn't cause termination.  This may be a Win2K issue.
 >
 >That file is being replaced - I have a shell script now that 
auto-generates
 >makefiles for gcc, VC6 and C++ Builder, it has better dependency 
checking,
 >and puts each build variation in its own sub-directory.  Something 
similar
 >could probably be leveraged for boost as a whole if required.  (I think
 >that if you check the zip an early version of the new VC6 makefile may 
have
 >made it in by mistake - called vc6_test.mak).  Let me know if you want to
 >take a look at these...

There is behind-the-scenes work going on develop real build scripting for 
boost.  Don't put a lot of work into build issues just now.

 >>*  Use of _MSC_VER to identify the Microsoft compiler.
 >
 >Don't you mean that should be BOOST_MSC_VER?

Yes, sorry, I wasn't clear.

Thanks,

--Beman