Re: [boost] Pool Review.

From: Peter Dimov (pdimov_at_[hidden])
Date: 2000-11-30 09:31:31

My pool comments:

I think that pool should be accepted into boost.

Code:

* headers end in .h, not .hpp;

* several changes were necessary to get pool to compile with MSVC 6sp4
(default STL) and g++ 2.95.2/mingw32 - see modified_pool.zip.

* mutex.h:

I think that mutex should be split into three separate classes,
detail::win32_mutex, detail::pthread_mutex, and
detail::single_threaded_mutex; mutex would be conditionally typedef'ed to
one of them. This will deal more gracefully with inconsistent definitions.

Win9x doesn't have trylock on a critical section; perhaps mutex::trylock()
ought to be removed?

Don't want to reopen an old debate but shouldn't lock/unlock be private and
accessible via guard<> only?

* feature request:

In some cases I have felt the need to define an std::vector<float> that
aligns their elements on, say, 128-bit boundaries (the Intel SSE, AMD 3DNow
extensions like their floats aligned.) Is it possible to pass a stricter
alignment requirement to pool_alloc?

* is it possible to get pool_alloc working with the MSVC 6 default STL? I'm
not an allocator expert.

Documentation:

* is there a list of the supported compilers? I haven't found one.

--
Peter Dimov
Multi Media Ltd.