crc

From: John Maddock (John_Maddock_at_[hidden])
Date: 2001-05-02 06:10:00

Daryle,

The latest crc code is getting there, but there are still problems:

I had to change:

    #ifndef __BORLANDC__
    #define BOOST_CRC_REF_OUT_VAL  reflect_output
    #else
    typedef crc_optimal  self_type;
    #define BOOST_CRC_REF_OUT_VAL  self_type::reflect_output
    #endif

to:

    #ifndef __BORLANDC__
    #define BOOST_CRC_REF_OUT_VAL  reflect_output
    #else
    typedef crc_optimal  self_type;
    #define BOOST_CRC_REF_OUT_VAL  (self_type::reflect_output)
    #endif

to get the code to compile with C++ Builder, otherwise, its OK.

With VC6, there are still template functions that have non-deduced non-type
parameters, and consequently still errors - one that caught my eye was
master_test, which is getting called with garbage values.  There may be
others elsewhere, looks like you will have to scower the header and the
test code for that idiom, if you want to get the code behaving correctly
under VC6.  At the very least there are the following:

template < std::size_t Bits, CRC_PARM_TYPE TrPo, CRC_PARM_TYPE InRe,
           CRC_PARM_TYPE FiXo, bool ReIn, bool ReRe >
    void  master_test( char const *test_name,
     typename boost::uint_t<Bits>::fast expected );

template < std::size_t Bits, CRC_PARM_TYPE TrPo, CRC_PARM_TYPE InRe,
           CRC_PARM_TYPE FiXo, bool ReIn, bool ReRe >
    void  compute_test( typename boost::uint_t<Bits>::fast expected );

template < std::size_t Bits, CRC_PARM_TYPE TrPo, CRC_PARM_TYPE InRe,
           CRC_PARM_TYPE FiXo, bool ReIn, bool ReRe >
    void  interrupt_test( typename boost::uint_t<Bits>::fast expected );

template < std::size_t Bits, CRC_PARM_TYPE TrPo, CRC_PARM_TYPE InRe,
           CRC_PARM_TYPE FiXo, bool ReIn, bool ReRe >
    void  error_test();

Just keep telling yourself that it's getting closer!  :-)

- John Maddock
http://ourworld.compuserve.com/homepages/john_maddock/