Re: Boost::Threads g++ warnings

From: williamkempf_at_[hidden]
Date: 2001-10-15 15:57:17

--- In boost_at_y..., "Peter Dimov" <pdimov_at_m...> wrote:
> From: <williamkempf_at_h...>
> > In file included from ../../../boost/limits.hpp:15,
> >                  from ../src\semaphore.cpp:14:
> > ../../../boost/detail/limits.hpp:102: macro `min' used without 
args
> 
> Try to #define NOMINMAX before #including <windows.h>.

Already done.  From the code (you can see it for yourself in CVS):

#if defined(BOOST_HAS_WINTHREADS)
#   define NOMINMAX
#   include <windows.h>

However, I have figured this one out.  The pthreads-win32 headers 
include <windows.h> so this one source file was indirectly including 
<windows.h> before NOMINMAX was defined, leading to the problem.  I 
guess my question is, should the Boost.Config stuff insure that all 
Win32 compilers have this defined up front?

And, while I'm at it, there's a set of gcc warnings given when 
compiling with native Win32 threads that I could use some help on as 
well.  Here's the output:

gcc-C++-
action ..\..\..\libs\thread\build\bin\libboost_thread\gcc\release\runt
im
e-link-dynamic\once.obj
../src\once.cpp: In function `void boost::call_once(void (*)(), 
once_flag &)':
../src\once.cpp:61: warning: unsigned int format, DWORD arg (arg 3)
../src\once.cpp:61: warning: unsigned int format, pointer arg (arg 4)

Bill Kempf