Re: Quick look at improved_numeric_cast

From: Daryle Walker (darylew_at_[hidden])
Date: 2001-10-31 11:31:07

on 10/30/01 11:48 AM, Fernando Cacciola at fcacciola_at_[hidden] wrote:

> ----- Original Message -----
> From: Daryle Walker <darylew_at_[hidden]>
> To: Boost <boost_at_[hidden]>
> Sent: Friday, October 26, 2001 10:47 PM
> Subject: [boost] Quick look at improved_numeric_cast
> 
> 
>> I'm looking at the archive at:
>> 
>> 
>> 
http://groups.yahoo.com/group/boost/files/improved_numeric_cast/numeric_cast
.zip
>> 
>> that I downloaded this afternoon.
>> 
>> It looks neat.  Let's try to get it to compile....
[SNIP]
>> 4.  You may want to use BOOST_NESTED_TEMPLATE and other macros to help with
>> older compilers.
>> 
>> I can't continue.  In "numeric_cast_traits_detail.hpp", my compiler is
>> expecting a comma after the BOOST_STATIC_CONSTANT of
>> boost::numeric_cast_traits_detail::subranged_int_to_int<T, S>::value.  I
>> later get an internal error in the same file.  Oh well, maybe this code is
>> too complex for my compiler (Metrowerks CodeWarrior Pro 5.3/Mac) to handle.
>> 
> 
> Daryle,
> 
> Thanks for all these comments!
> I rearranged the code a little based on the line were the error ocurred,
> after I guessed what could have been that MCW didn't like.
> I hope this made it compile with more compilers than BC5.5.1
> For now, I uploaded ONLY the archive "numeric_cast.zip"
> Could you check this please?
> 
> I haven't applied the changes suggested by Darin Adler, yet, since those are
> interface changes -but I agreed with him-
> I'll wait for more feedback before I start with the syntatic/semantic
> changes.

The comment blurbs at the beginning of your files have a different line
ending character set than the rest of their files, making my IDE give
inconsistent line ending errors.  Check that out on your own editor.  It
does cause some problems with locating errors and with the first #if of a
file being part of the initial comments.

The strange comma problem is still there.  My compiler says:

Error   : ',' expected
meta_programing_tools.hpp line 90   static const bool value = ( X::value <
Y::value )

Where the line is:

    BOOST_STATIC_CONSTANT ( bool, value = ( X::value < Y::value ) ) ;

And the space before the semicolon is highlighted.  Either my compiler has a
serious parser error, or you forgot something earlier in your code.  (I
originally had the error on line 79 on the first colon after the "Y," but
the line-ending fix moved the mark.)

I also still get the internal compiler error:

Error   : internal compiler error: File: 'CTemplateTools.c' Line: 1553
numeric_cast_traits_detail.hpp line 71             type ;

with the semicolon highlighted.

-- 
Daryle Walker
Mac, Internet, and Video Game Junkie
darylew AT mac DOT com