Re: Use common_factor.hpp?

From: pf_moore (gustav_at_[hidden])
Date: 2001-12-15 17:05:41

--- In boost_at_y..., "Moore, Paul" <paul.moore_at_a...> wrote:
> Will you put this in the GCD documentation? I don't want to chop
> that chunk out of rational and replace it with "see the GCD
> documentation" if the user will then find it's not there...

OK. I tried to switch to boost/math/common_factor.hpp.

The change should be simple. Include the header, and change all uses 
of "gcd" to "boost::math::gcd".

Did that, then tried to compile the regression test.

>cl /I..\.. /GX rational_test.cpp
Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 12.00.8804 for
80x86 Copyright (C) Microsoft Corp 1984-1998. All rights reserved.

rational_test.cpp
rational_test.cpp(111) : fatal error C1001: INTERNAL COMPILER ERROR
        (compiler file 'msc1.cpp', line 1794)
         Please choose the Technical Support command on the Visual C++
         Help menu, or open the Technical Support help file for more
         information

Blow this for a lark. If boost::math::gcd isn't a total drop-in 
replacement for my gcd on MSVC, I'm not changing it.

If anyone wants to resolve this and confirm that rational_test.cpp 
*works* under MSVC 6 (SP5), then I'll give it another go. But I 
haven't the time or inclination to bother messing with working code 
just to delete 43 lines of code (including comments).

And what reassurance does this give me that boost::math::gcd won't 
break on another compiler where my code works?

Why did such a simple function turn into such a complicated maze?

Paul.