Re: [boost] Rational library patch

From: Beman Dawes (bdawes_at_[hidden])
Date: 2002-02-17 20:23:59

At 03:52 AM 2/15/2002, Moore, Paul wrote:

 >Did anyone pick up and apply the patch I sent earlier this week?

Yes, just applied to CVS.

Tested on Win32 (after new tests added to rational_test.cpp):

   Before rational.hpp patch:  All compilers failed.

   After rational.hpp patch: All compilers except GCC 2.95.3-5 passed.

The GCC failure has been failing in past tests; see below.

--Beman

** GCC under cygwin
g++ -o boosttmp.exe -ftemplate-depth-40 -Ic:/boost/site 
c:/boost/site/libs/rational/rational_test.cpp
4.20 s

boosttmp.exe
Running tests for boost::rational<long>

Implementation issue: the minimal size for a rational
is twice the size of the underlying integer type.

Checking to see if space is being wasted.
     sizeof(long) == 4
     sizeof(boost::rational<long>) == 12

Implementation has included padding bytes

Failed test ( !iss ) at line 337
139/140 tests succeeded (99%).
0.15 s

Return code: 1
Fail