[patch] Boost.Signals + diatribe (Re: [signals] Re: [boost] take-2 [patch] usage of asserts with pointers in boost)

From: Lars Gullik Bjønnes (larsbj_at_[hidden])
Date: 2002-08-07 07:04:09

"Peter Dimov" <pdimov_at_[hidden]> writes:

| From: "Lars Gullik Bjønnes" <larsbj_at_[hidden]>
>> This is a patch to avoid warnings when compiling on 64bit platforms.
>>
>> a comment would be nice...
>
| When posting patches, please mention the libraries that the patch applies to
| (Boost.Signals in this case) so that Doug's mail reader can move the message
| to the appropriate folder. :-) Thanks.

[ahh how clever...]

This is one of the patches I mentioned in a thread ealier that does
not fit with one single library, but rather to _all_ libraries that
use assert on pointers. IMHO this also shows the problem with "my lib
and his lib", and cross lib maintenance.

You really need some Janitor-Wizard.

Anyhow, I'd like this patch to go in.

Thanks.

| --
>
| Index: boost/boost/signals/connection.hpp
| ===================================================================
| RCS file:
| /usr/local/lyx/cvsroot/lyx-devel/boost/boost/signals/connection.hpp,v
| retrieving revision 1.6
| diff -u -p -r1.6 connection.hpp
| --- boost/boost/signals/connection.hpp 28 Jul 2002 23:38:38 -0000 1.6
| +++ boost/boost/signals/connection.hpp 6 Aug 2002 10:46:03 -0000
| @@ -151,7 +151,7 @@ namespace boost {
|      inline void
|      connection::add_bound_object(const
| BOOST_SIGNALS_NAMESPACE::detail::bound_object& b)
|      {
| -      assert(con.get());
| +      assert(con.get() != 0);
|        con->bound_objects.push_back(b);
|      }
>
| Index: boost/libs/signals/src/connection.cpp
| ===================================================================
| RCS file:
| /usr/local/lyx/cvsroot/lyx-devel/boost/libs/signals/src/connection.cpp,v
| retrieving revision 1.5
| diff -u -p -r1.5 connection.cpp
| --- boost/libs/signals/src/connection.cpp 28 Jul 2002 23:38:39 -0000 1.5
| +++ boost/libs/signals/src/connection.cpp 6 Aug 2002 10:46:04 -0000
| @@ -39,7 +39,7 @@ namespace boost {
|          typedef
| std::list<BOOST_SIGNALS_NAMESPACE::detail::bound_object>::iterator iterator;
|          for (iterator i = local_con->bound_objects.begin();
|               i != local_con->bound_objects.end(); ++i) {
| -          assert(i->disconnect);
| +          assert(i->disconnect != 0);
|            i->disconnect(i->obj, i->data);
|          }
|        }
>
>
| _______________________________________________
| Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
>

-- 
	Lgb